Skip to content

sit.cephfs: Disable posix locking for durable handles #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 2, 2025
Merged

sit.cephfs: Disable posix locking for durable handles #142

merged 1 commit into from
Oct 2, 2025

Conversation

anoopcs9
Copy link
Collaborator

@anoopcs9 anoopcs9 commented Sep 29, 2025 •
edited
Loading

Durable handles are only enabled with kernel oplocks, kernel share modes and posix locking disabled. But with mgr variant posix locking was not explicitly disabled and thus few tests failed.

# smbtorture \\\\192.168.122.101\\demoshare -U user%passwd --target=samba3 smb2.durable-open.lock-lease
smbtorture 4.24.0pre1-GIT-33762753f03
Using seed 1759143394
time: 2025-09-29 10:56:34.770112
test: lock-lease
time: 2025-09-29 10:56:34.770708
time: 2025-09-29 10:56:39.831182
failure: lock-lease [
../../source4/torture/smb2/durable_open.c:2451: status was NT_STATUS_OBJECT_NAME_NOT_FOUND, expected NT_STATUS_OK: ../../source4/torture/smb2/durable_open.c:2451
]

# smbtorture \\\\192.168.122.101\\demoshare -U user%passwd --target=samba3 smb2.durable-open.lock-oplock
smbtorture 4.24.0pre1-GIT-33762753f03
Using seed 1759143435
time: 2025-09-29 10:57:15.976920
test: lock-oplock
time: 2025-09-29 10:57:15.977286
time: 2025-09-29 10:57:23.846668
failure: lock-oplock [
../../source4/torture/smb2/durable_open.c:2352: status was NT_STATUS_OBJECT_NAME_NOT_FOUND, expected NT_STATUS_OK: ../../source4/torture/smb2/durable_open.c:2352
]

smbd logs:

Sep 29 16:26:39 dev-vm-2 ceph-441d6a82-7423-11f0-9199-52540002ea9e-smb-demosmb-1-0-dev-vm-2-ygayax[103937]: vfs_default_durable_reconnect_fn: vfs_default_durable_cookie - NT_STATUS_NOT_SUPPORTED
Sep 29 16:26:39 dev-vm-2 ceph-441d6a82-7423-11f0-9199-52540002ea9e-smb-demosmb-1-0-dev-vm-2-ygayax[103937]: vfs_default_durable_reconnect: default_durable_reconnect_fn [durable_open_lease_lock_tlgt3-dF.dat] failed: NT_STATUS_NOT_SUPPORTED

@anoopcs9
sit.cephfs: Disable posix locking for durable handles
cce32d1 
Durable handles are only enabled with "kernel oplocks", "kernel
share modes" and "posix locking" disabled. But with mgr variant
"posix locking" was not explicitly disabled and thus few tests
failed.

Signed-off-by: Anoop C S <[email protected]>
@anoopcs9 anoopcs9 force-pushed the disable-posix-locking branch from 410f813 to cce32d1 Compare September 29, 2025 10:19
@anoopcs9 anoopcs9 changed the title sit.cephfs: Disable posix locking for durable hanldes sit.cephfs: Disable posix locking for durable handles Sep 29, 2025
@anoopcs9 anoopcs9 merged commit 8379b37 into samba-in-kubernetes:main Oct 2, 2025
7 checks passed
@anoopcs9 anoopcs9 deleted the disable-posix-locking branch October 2, 2025 18:00
@spuiuk spuiuk mentioned this pull request Oct 6, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xhernandez xhernandez xhernandez approved these changes

@spuiuk spuiuk Awaiting requested review from spuiuk

@phlogistonjohn phlogistonjohn Awaiting requested review from phlogistonjohn

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@anoopcs9 @xhernandez